vibhatha commented on code in PR #13448:
URL: https://github.com/apache/arrow/pull/13448#discussion_r908578398
##########
cpp/src/arrow/compute/exec/exec_plan.cc:
##########
@@ -85,11 +85,9 @@ struct ExecPlanImpl : public ExecPlan {
#ifdef ARROW_WITH_OPENTELEMETRY
if (HasMetadata()) {
auto pairs = metadata().get()->sorted_pairs();
- opentelemetry::nostd::shared_ptr<opentelemetry::trace::Span> span =
- ::arrow::internal::tracing::UnwrapSpan(span_.details.get());
std::for_each(std::begin(pairs), std::end(pairs),
- [span](std::pair<std::string, std::string> const& pair) {
- span->SetAttribute(pair.first, pair.second);
+ [this](std::pair<std::string, std::string> const& pair) {
+ span_.Get().span->SetAttribute(pair.first, pair.second);
});
}
#endif
Review Comment:
**TODO**: this is a typo fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
