lidavidm commented on code in PR #13458: URL: https://github.com/apache/arrow/pull/13458#discussion_r909542318
########## cpp/src/jni/CMakeLists.txt: ########## @@ -18,10 +18,6 @@ # # arrow_jni # -if(ARROW_ORC) - add_subdirectory(orc) Review Comment: I think we'll want to keep the `if(ARROW_ORC)` (and move it to the other file) ########## cpp/CMakeLists.txt: ########## @@ -980,6 +980,7 @@ endif() if(ARROW_JNI) add_subdirectory(src/jni) + add_subdirectory(../java/adapter/orc/src/main/cpp ./java/jni) Review Comment: Does the `./java/jni` directory actually do anything here it doesn't exist? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
