westonpace commented on code in PR #13390:
URL: https://github.com/apache/arrow/pull/13390#discussion_r910177440
##########
cpp/src/arrow/util/uri.cc:
##########
@@ -208,6 +208,12 @@ std::string Uri::path() const {
return std::move(ss).str();
}
+std::string Uri::extension() const {
+ std::string filename = impl_->path_segments_.back().to_string();
+ size_t extension_index = filename.find(".");
Review Comment:
This entire block of code is converting a Substrait LocalFiles into a
FileSystemDataset so I think its safe to rely on `ARROW_FILESYSTEM` methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
