tustvold commented on code in PR #1935:
URL: https://github.com/apache/arrow-rs/pull/1935#discussion_r910258249
##########
parquet/src/file/metadata.rs:
##########
@@ -519,6 +527,26 @@ impl ColumnChunkMetaData {
self.offset_index_length
}
+ /// Set File offset of ColumnChunk's OffsetIndex
+ pub fn set_offset_index_offset(&mut self, offset_index_offset: i64) {
+ self.offset_index_offset = Some(offset_index_offset);
+ }
+
+ /// Set Size of ColumnChunk's OffsetIndex, in bytes
+ pub fn set_offset_index_length(&mut self, offset_index_length: i32) {
+ self.offset_index_length = Some(offset_index_length);
+ }
+
+ /// Set File offset of ColumnChunk's ColumnIndex
+ pub fn set_column_index_offset(&mut self, column_index_offset: i64) {
+ self.column_index_offset = Some(column_index_offset);
+ }
+
+ /// Set Size of ColumnChunk's ColumnIndex, in bytes
+ pub fn set_column_index_length(&mut self, column_index_length: i32) {
+ self.column_index_length = Some(column_index_length);
+ }
+
Review Comment:
These aren't used anymore
##########
parquet/src/file/metadata.rs:
##########
@@ -247,6 +250,11 @@ impl RowGroupMetaData {
&self.columns
}
+ /// Returns mut slice of column chunk metadata
+ pub fn columns_mut(&mut self) -> &mut [ColumnChunkMetaData] {
Review Comment:
This isn't used anymore
##########
parquet/src/column/writer.rs:
##########
@@ -162,6 +164,14 @@ pub fn get_typed_column_writer_mut<'a, 'b: 'a, T:
DataType>(
})
}
+type ColumnCloseResult = (
Review Comment:
I wonder if we should make this a struct instead, definitely something we
could do in a subsequent PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
