kou commented on code in PR #12914:
URL: https://github.com/apache/arrow/pull/12914#discussion_r910495854
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -114,16 +114,20 @@ elseif(ARROW_CPU_FLAG STREQUAL "armv8")
endif()
# Support C11
-if(NOT DEFINED CMAKE_C_STANDARD)
+if("${CMAKE_C_STANDARD}" STREQUAL "")
Review Comment:
It was added by me.
We can accept `-DCMAKE_C_STANDARD=`/`-DCMAKE_CXX_STANDARD=` (empty value) by
this change. We always specify `CMAKE_C_STANDARD`/`CMAKE_CXX_STANDARD` in our
build script:
https://github.com/apache/arrow/blob/master/ci/scripts/cpp_build.sh#L142-L143
We can use the default value by specifying an empty value with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
