nealrichardson commented on code in PR #13397:
URL: https://github.com/apache/arrow/pull/13397#discussion_r910496587


##########
r/R/query-engine.R:
##########
@@ -190,7 +190,7 @@ ExecPlan <- R6Class("ExecPlan",
       }
       node
     },
-    Run = function(node) {
+    Run = function(node, as_table = FALSE) {

Review Comment:
   Hmm. I think this is a problem. It sounds like UDFs will just fail if you 
try to stream an RBR into something else (currently I'm thinking of the duckdb 
integration, but there are potentially other applications). I don't think we 
want to impose that limitation if we can avoid it--just thinking of the 
cognitive overhead added every time we have to explain "well it usually works 
if you do X but not in cases Y and Z", not to mention the constraint on ways 
you can compose Arrow. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to