davisusanibar commented on code in PR #13458: URL: https://github.com/apache/arrow/pull/13458#discussion_r911229061
########## cpp/src/jni/CMakeLists.txt: ########## @@ -18,10 +18,6 @@ # # arrow_jni # -if(ARROW_ORC) - add_subdirectory(orc) Review Comment: Oh ok clear, let me add that logic on `java/adapter/orc/src/main/cpp` not in `cpp/src/jni/CMakeLists.txt` Related to the intended: For the ticket related to “Consolidate JNI compilation ORC ARROW-16930 / Dataset ARROW-16941”. Currently: ORC JNI / Dataset JNI are inside of ./cpp directory Changes to Consolidate JNI compilation ORC / Dataset: 1st Phase: 1. Move ORC JNI / Dataset JNI from ./cpp to ./java directory 2. Delete ORC JNI / Dataset JNI from ./cpp 2. Continue building ORC / Dataset from ./cpp as you see at https://github.com/apache/arrow/blob/6bd03d409a687011b8d4b66e491015128f1ae27e/ci/scripts/java_jni_macos_build.sh#L52:L87 with the aggregation that this is using now ./java directory instead of cpp/src/jni directory 2nd Phase: 1. Building ORC / Dataset directly from ./java directory as a maven project “mvn clean install ...” This phase involve lots of changes Java code + CMakeList + CI CD changes Phase 1 will be implemented by this PR: Dataset (https://github.com/apache/arrow/pull/13481) / ORC (https://github.com/apache/arrow/pull/13458) Phase 2: We are going to create ticket and maintain that on the backlog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
