thisisnic commented on code in PR #13482:
URL: https://github.com/apache/arrow/pull/13482#discussion_r911390034
##########
r/tests/testthat/test-Table.R:
##########
@@ -696,3 +696,18 @@ test_that("as_arrow_table() errors for invalid input", {
class = "arrow_no_method_as_arrow_table"
)
})
+
+test_that("ARROW-14989: num_rows method not susceptible to integer overflow", {
+ skip_on_cran()
+
+ test_array1 <- Array$create(raw(.Machine$integer.max))
Review Comment:
In fact, they're dying on CI. Perhaps I leave them in for the PR review as
they demonstrate the intended change here actually works and can be ran
locally, but then I delete them once it's confirmed all looks good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
