wjones127 commented on code in PR #13486:
URL: https://github.com/apache/arrow/pull/13486#discussion_r912064619
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3834,7 +3834,55 @@ macro(build_grpc)
list(APPEND
ARROW_BUNDLED_STATIC_LIBS
- ${GRPC_GPR_ABSL_LIBRARIES}
+ # This list of absl dependencies can be generated with:
+ # pkg-config --libs --static grpc \
+ # | tr " " "\n" \
+ # | grep ^-labsl_ \
+ # | sed 's/^-labsl_/absl::/'
Review Comment:
hmm I suppose I should have just done that. I was thinking that
`GRPC_GPR_ABSL_LIBRARIES` was meant to hold the top-level Abseil dependencies
of gRPC, while for the static library list we need a flattened set of
libraries. That is, the static library list not only needs to contain
`absl::cord`, but also `absl::cord_zinfo`, but most other functions using the
target can find the nested dependency automatically. But I guess there's no
reason not to use a flattened list everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
