kou commented on code in PR #13453: URL: https://github.com/apache/arrow/pull/13453#discussion_r912251599
########## .github/actions/sync-nightlies/action.yml: ########## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: 'Sync nightlies' +description: 'Sync files to and from nightlies.apache.org' +inputs: + upload: + description: 'Sync from local to remote' + default: false + required: false + switches: + description: 'see rsync --help' + required: true + local_path: + description: 'The relative local path within $GITHUB_WORKSPACE' + required: true + remote_path: + description: 'The remote path incl. sub dirs e.g. {{secrets.path}}/arrow/r' + required: true + remote_host: + description: 'The remote host' + required: true + remote_port: + description: 'The remote port' + required: false + default: 22 + remote_user: + description: 'The remote user' + required: true + remote_key: + description: 'The remote key' + required: true + remote_host_key: + description: 'The host key for StrictHostKeyChecking' + + required: true + +runs: + using: "composite" + steps: + - name: Sync files + shell: bash + env: + SWITCHES: "${{ inputs.switches }}" + LOCAL_PATH: "${{ github.workspace }}/${{ inputs.local_path }}" + + SSH_KEY: "${{ inputs.remote_key }}" + PORT: "${{ inputs.remote_port }}" + USER: "${{ inputs.remote_user }}" + HOST: "${{ inputs.remote_host }}" + HOST_KEY: "${{ inputs.remote_host_key }}" + REMOTE_PATH: "${{ inputs.remote_path }}" + run: | + # Make SSH key available and add remote to known hosts + eval "$(ssh-agent)" > /dev/null + echo "$SSH_KEY" | tr -d '\r' | ssh-add - >/dev/null + + mkdir -p .ssh + chmod go-rwx .ssh + echo "$HOST_KEY" >> .ssh/known_hosts + + # strict errors + set -eu + + # We have to use a custom RSH to supply the port + RSH="ssh -o UserKnownHostsFile=.ssh/known_hosts -p $PORT" + DSN="$USER@$HOST" + + # It is important to append '/' to the source path otherwise Review Comment: > How about we check if `SOURCE` is a directory or file and only add a slash if it is a directory and does not already have a trailing slash? If we use this approach, we can't copy `src/` to `dest/src/` by `local_path: src` (no trailing slash). If you don't like the "appending `/` in caller" approach, I'm OK with the current approach. But could you add a comment that "this action supports only directory as source" or something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
