tustvold opened a new pull request, #1995:
URL: https://github.com/apache/arrow-rs/pull/1995
# Which issue does this PR close?
Miscellaneous cleanup whilst working on #1792
# Rationale for this change
The existing code had redundant result returns, duplicated logic, and
confusing semantics.
# What changes are included in this PR?
Changes the semantics of ColumnReader::read_batch to error if called on data
without the necessary levels buffers, and to return the number of levels read
even for columns that have max_def_level == 0 && max_rep_level == 0. This is
technically a breaking change, although I think it makes the API a lot less
confusing.
Cleanups some additional code
# Are there any user-facing changes?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
