Ted-Jiang commented on code in PR #1998:
URL: https://github.com/apache/arrow-rs/pull/1998#discussion_r912605881
##########
parquet/src/arrow/arrow_reader.rs:
##########
@@ -86,11 +117,24 @@ impl ArrowReaderOptions {
///
/// For
example:[ARROW-16184](https://issues.apache.org/jira/browse/ARROW-16184)
///
-
/// Set `skip_arrow_metadata` to true, to skip decoding this
pub fn with_skip_arrow_metadata(self, skip_arrow_metadata: bool) -> Self {
Self {
skip_arrow_metadata,
+ ..self
+ }
+ }
+
+ /// Scan rows from the parquet file according to the provided `selection`
+ ///
+ /// TODO: Make public once row selection fully implemented
+ pub(crate) fn with_row_selection(
+ self,
+ selection: impl Into<Vec<RowSelection>>,
+ ) -> Self {
Review Comment:
I think we should add total_row_count, check this selection is valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
