kou commented on code in PR #13511:
URL: https://github.com/apache/arrow/pull/13511#discussion_r913303572
##########
dev/archery/archery/crossbow/cli.py:
##########
@@ -155,6 +155,49 @@ def submit(obj, tasks, groups, params, job_prefix,
config_path, arrow_version,
click.echo('Pushed job identifier is: `{}`'.format(job.branch))
[email protected]()
[email protected]('--base-branch', '-b', default="master",
+ help='Set base branch for the PR.')
[email protected]('--arrow-remote', '-r', default=None,
+ help='Set GitHub remote explicitly, which is going to be used '
+ 'for the PR. Note, that no validation happens '
+ 'locally. Examples: https://github.com/apache/arrow or '
+ 'https://github.com/raulcd/arrow.')
[email protected]('--head-branch', '-h', default=None,
+ help='Give the branch name explicitly, e.g. release-9.0.0-rc0')
[email protected]('--pr-title', '-t', default=None,
+ help='Set title for the PR.')
[email protected]('--pr-body', '-d', default=None,
+ help='Set body for the PR.')
[email protected]('--create-pr', is_flag=True, default=False,
+ help='Create Github Pull Request')
[email protected]('--rc', '-c', default=None,
+ help='Relase Candidate number.')
[email protected]('--version', '-r', default=None,
+ help='Release version.')
[email protected]('--arrow-token', envvar='ARROW_GITHUB_TOKEN',
Review Comment:
How about using `--github-token` because this is a token for GitHub?
##########
dev/release/02-source.sh:
##########
@@ -123,6 +126,18 @@ if [ ${SOURCE_UPLOAD} -gt 0 ]; then
echo ""
fi
+# Create Pull Request and Crossbow comment to run Verification tasks
+if [ ${SOURCE_PR} -gt 0 ]; then
+ archery crossbow verify-release-candidate \
+ --base-branch=${maint_branch} \
+ --arrow-remote=https://github.com/apache/arrow \
+ --head-branch=${release_candidate_branch} \
+ --pr-title="WIP: [Release] Verify ${release_candidate_branch}" \
+ --pr-body="PR to verify Release Candidate" \
+ --version=${version} --rc=${rc} \
+ --arrow-token=${ARROW_GITHUB_TOKEN} --create-pr
Review Comment:
Could you indent continuous lines and sort alphabetically?
```suggestion
--arrow-remote=https://github.com/apache/arrow \
--arrow-token=${ARROW_GITHUB_TOKEN} \
--base-branch=${maint_branch} \
--create-pr \
--head-branch=${release_candidate_branch} \
--pr-body="PR to verify Release Candidate" \
--pr-title="WIP: [Release] Verify ${release_candidate_branch}" \
--rc=${rc} \
--version=${version}
```
##########
dev/archery/archery/crossbow/cli.py:
##########
@@ -155,6 +155,49 @@ def submit(obj, tasks, groups, params, job_prefix,
config_path, arrow_version,
click.echo('Pushed job identifier is: `{}`'.format(job.branch))
[email protected]()
[email protected]('--base-branch', '-b', default="master",
Review Comment:
It seems that we don't need short options such as `-b` because we run this
from `02-source.sh`.
##########
dev/archery/archery/crossbow/cli.py:
##########
@@ -155,6 +155,49 @@ def submit(obj, tasks, groups, params, job_prefix,
config_path, arrow_version,
click.echo('Pushed job identifier is: `{}`'.format(job.branch))
[email protected]()
[email protected]('--base-branch', '-b', default="master",
+ help='Set base branch for the PR.')
[email protected]('--arrow-remote', '-r', default=None,
Review Comment:
How about `--remote` instead of `--arrow-remote`?
It seems that `arrow-` is redundant in this context.
##########
dev/archery/archery/crossbow/cli.py:
##########
@@ -155,6 +155,49 @@ def submit(obj, tasks, groups, params, job_prefix,
config_path, arrow_version,
click.echo('Pushed job identifier is: `{}`'.format(job.branch))
[email protected]()
[email protected]('--base-branch', '-b', default="master",
+ help='Set base branch for the PR.')
[email protected]('--arrow-remote', '-r', default=None,
+ help='Set GitHub remote explicitly, which is going to be used '
+ 'for the PR. Note, that no validation happens '
+ 'locally. Examples: https://github.com/apache/arrow or '
+ 'https://github.com/raulcd/arrow.')
[email protected]('--head-branch', '-h', default=None,
+ help='Give the branch name explicitly, e.g. release-9.0.0-rc0')
[email protected]('--pr-title', '-t', default=None,
+ help='Set title for the PR.')
[email protected]('--pr-body', '-d', default=None,
+ help='Set body for the PR.')
[email protected]('--create-pr', is_flag=True, default=False,
+ help='Create Github Pull Request')
Review Comment:
```suggestion
help='Create GitHub Pull Request')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
