Ted-Jiang commented on code in PR #1998:
URL: https://github.com/apache/arrow-rs/pull/1998#discussion_r913328966
##########
parquet/src/arrow/record_reader/mod.rs:
##########
@@ -202,6 +203,37 @@ where
Ok(records_read)
}
+ /// Try to skip the next `num_records` rows
+ ///
+ /// # Returns
+ ///
+ /// Number of records skipped
+ pub fn skip_records(&mut self, num_records: usize) -> Result<usize> {
+ // First need to clear the buffer
+ let (buffered_records, buffered_values) =
self.count_records(num_records);
+ self.num_records += buffered_records;
+ self.num_values += buffered_values;
+
+ self.consume_def_levels();
+ self.consume_rep_levels();
+ self.consume_record_data();
+ self.consume_bitmap();
+ self.reset();
+
+ let remaining = buffered_records - num_records;
Review Comment:
both `buffered_records ` and `buffered_records` are usize it will overflow,
and if `remaining ` is nagtive how to use in `
column_reader.skip_records(remaining)?,`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
