amol- commented on code in PR #13409:
URL: https://github.com/apache/arrow/pull/13409#discussion_r913679727
##########
cpp/src/arrow/compute/exec/options.cc:
##########
@@ -61,5 +61,16 @@ Result<std::shared_ptr<SourceNodeOptions>>
SourceNodeOptions::FromTable(
new SourceNodeOptions(table.schema(), batch_gen));
}
+Result<std::shared_ptr<SourceNodeOptions>>
SourceNodeOptions::FromRecordBatchReader(
+ std::shared_ptr<RecordBatchReader> reader, std::shared_ptr<Schema> schema,
+ arrow::internal::Executor* exc) {
Review Comment:
I copied the original signature from the previous
`SourceNodeOptions::FromTable` which had `exec`. I renamed the parameter in
both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
