pitrou commented on code in PR #13246:
URL: https://github.com/apache/arrow/pull/13246#discussion_r913946778
##########
java/dataset/src/main/cpp/jni_util.h:
##########
@@ -91,6 +93,24 @@ void ReleaseNativeRef(jlong ref) {
delete retrieved_ptr;
}
+const char kJavaErrorDetailTypeId[] = "arrow::dataset::jni::JavaErrorDetail";
Review Comment:
Should this be a `static` member inside `JavaErrorDetail`, or perhaps
`extern` and defined in the `.cc`?
As is, it seems there will be symbol clashes if `jni_util.h` is included by
several `.cc` files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
