rok commented on code in PR #13462:
URL: https://github.com/apache/arrow/pull/13462#discussion_r913957782
##########
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc:
##########
@@ -409,6 +409,60 @@ class ScalarTemporalTest : public ::testing::Test {
RoundTemporalOptions(15, CalendarUnit::QUARTER);
RoundTemporalOptions round_to_15_years = RoundTemporalOptions(15,
CalendarUnit::YEAR);
+ RoundTemporalOptions round_to_1_nanoseconds_2 =
+ RoundTemporalOptions(1, CalendarUnit::NANOSECOND, true, true, false);
Review Comment:
Oh that was wrong. Fixed.
The reason the tests passed is because the error
(`calendar_based_origin=true`) was only there for `multiple=1` which would
return (mostly) equal for `calendar_based_origin=true` or
`calendar_based_origin=false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
