wjones127 commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r914161355
##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -278,7 +288,8 @@ class GcsIntegrationTest : public ::testing::Test {
class TestGCSFSGeneric : public GcsIntegrationTest, public
GenericFileSystemTest {
public:
void SetUp() override {
- GcsIntegrationTest::SetUp();
+ GcsIntegrationTest::SetUp(); // Setup failure is not propagating
+ ASSERT_TRUE(Testbench()->running());
Review Comment:
One problem is the `SetUp()` assertion failures are not propagating to the
child. The method just exits early and then the outer `SetUp()` continues as
normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
