westonpace commented on PR #13366: URL: https://github.com/apache/arrow/pull/13366#issuecomment-1175595939
How about this: https://github.com/apache/arrow/commit/f7109966366f389ba3bace571aa55571f70b2aec * moves the benchmark utilities for exec plans into a new benchmark_util that is in the compute/exec folder. This change isn't strictly necessary but helps keep the code separated. * removes any dependency on googletest and instead changes the functions to return a status. Then only the benchmark needs to depend on googletest (and can do ASSERT_OK in one spot). * changes the build slightly so that the benchmark_util.cc file is only built when building benchmarks so that this code doesn't get included with the libarrow.so (or libarrow_compute.so) files. Locally, tests seem to pass on my fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
