pitrou commented on a change in pull request #8163:
URL: https://github.com/apache/arrow/pull/8163#discussion_r487912911



##########
File path: cpp/src/arrow/compute/api_aggregate.h
##########
@@ -66,7 +66,7 @@ struct ARROW_EXPORT MinMaxOptions : public FunctionOptions {
     /// Skip null values
     SKIP = 0,
     /// Any nulls will result in null output
-    OUTPUT_NULL
+    EMIT_NULL

Review comment:
       The next version will be 2.0.0, meaning it's ok to break APIs. Of 
course, we should try to minimize breakage, but this one aims to fix an 
inconsistency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to