vibhatha commented on PR #13130: URL: https://github.com/apache/arrow/pull/13130#issuecomment-1175716618
> This looks correct. I have a few questions. Maybe it would be good to also add an end-to-end test now that we have Substrait working in python? @westonpace I was also thinking about this. I sort of roughly sketched it mentally like this. Create a test suite for substrait in Python where we use the `testing` dataset or any generated data to do the dataflow operations and add unit tests for each relation in a set of PRs. Since we have incorporated more relations now, I think a few small PRs can help with this. I will go ahead and add a JIRA to record this. By the way we were thinking about saving space for the lengthy strings required for creating Substrait plans. Is it in action now or if not we can integrate it later on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
