andygrove commented on PR #2830: URL: https://github.com/apache/arrow-datafusion/pull/2830#issuecomment-1176312549
> > I do find create_statement misleading because this method is not creating a statement. How about something like get_table_create_sql or maybe just get_table_sql ? > > That makes sense for the `TableProvider` method, what about the name of the column in `information_schema.tables`? `definition` there to match MySQL? Yes `definition` seems reasonable. Maybe the method name should use the same term ... `get_table_definition` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
