Ted-Jiang commented on code in PR #2012:
URL: https://github.com/apache/arrow-rs/pull/2012#discussion_r916416883
##########
parquet/src/file/page_index/index.rs:
##########
@@ -56,6 +56,7 @@ pub enum Index {
DOUBLE(NativeIndex<f64>),
BYTE_ARRAY(ByteArrayIndex),
FIXED_LEN_BYTE_ARRAY(ByteArrayIndex),
+ EMPTY_ARRAY(),
Review Comment:
I think change `Index` to `Option<Index>` need write a lot useless code. Use
`None` will change a lot of func to `.....()->Option<Index>`.
I think add `EMPTY_ARRAY ` is more convenient😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
