lidavidm commented on code in PR #13547:
URL: https://github.com/apache/arrow/pull/13547#discussion_r916748719
##########
cpp/src/arrow/flight/sql/CMakeLists.txt:
##########
@@ -117,10 +117,4 @@ if(ARROW_BUILD_TESTS OR ARROW_BUILD_EXAMPLES)
add_executable(flight-sql-test-app test_app_cli.cc)
target_link_libraries(flight-sql-test-app PRIVATE
${ARROW_FLIGHT_SQL_TEST_LINK_LIBS}
${GFLAGS_LIBRARIES})
-
- if(ARROW_FLIGHT_TEST_LINKAGE STREQUAL "static" AND ARROW_BUILD_STATIC)
- target_compile_definitions(flight_sql_test
Review Comment:
```diff
if(ARROW_FLIGHT_TEST_LINKAGE STREQUAL "static" AND ARROW_BUILD_STATIC)
- target_compile_definitions(flight_sql_test
- flight-sql-test-server flight-sql-test-app
- PUBLIC ARROW_FLIGHT_STATIC
ARROW_FLIGHT_SQL_STATIC)
+ foreach(TEST_TARGET arrow-flight-sql-test flight-sql-test-server
flight-sql-test-app)
+ target_compile_definitions(${TEST_TARGET}
+ PUBLIC ARROW_FLIGHT_STATIC
ARROW_FLIGHT_SQL_STATIC)
+ endforeach()
endif()
```
##########
cpp/src/arrow/flight/sql/CMakeLists.txt:
##########
@@ -117,10 +117,4 @@ if(ARROW_BUILD_TESTS OR ARROW_BUILD_EXAMPLES)
add_executable(flight-sql-test-app test_app_cli.cc)
target_link_libraries(flight-sql-test-app PRIVATE
${ARROW_FLIGHT_SQL_TEST_LINK_LIBS}
${GFLAGS_LIBRARIES})
-
- if(ARROW_FLIGHT_TEST_LINKAGE STREQUAL "static" AND ARROW_BUILD_STATIC)
- target_compile_definitions(flight_sql_test
Review Comment:
```diff
if(ARROW_FLIGHT_TEST_LINKAGE STREQUAL "static" AND ARROW_BUILD_STATIC)
- target_compile_definitions(flight_sql_test
- flight-sql-test-server flight-sql-test-app
- PUBLIC ARROW_FLIGHT_STATIC
ARROW_FLIGHT_SQL_STATIC)
+ foreach(TEST_TARGET arrow-flight-sql-test flight-sql-test-server
flight-sql-test-app)
+ target_compile_definitions(${TEST_TARGET}
+ PUBLIC ARROW_FLIGHT_STATIC
ARROW_FLIGHT_SQL_STATIC)
+ endforeach()
endif()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
