nealrichardson commented on code in PR #13514:
URL: https://github.com/apache/arrow/pull/13514#discussion_r916904109
##########
r/tests/testthat/test-Table.R:
##########
@@ -696,3 +696,18 @@ test_that("as_arrow_table() errors for invalid input", {
class = "arrow_no_method_as_arrow_table"
)
})
+
+test_that("num_rows method not susceptible to integer overflow", {
Review Comment:
These large memory tests are slow, so I don't think you need two versions, I
think you can keep just the Table version.
If you want to test more places r_vec_size is used, you can get `$nbytes()`
on the arrays/chunkedarrays, as well as `length()`. You can also get
`array$data()` and check its length (that one might not be covered yet...) and
get $buffers from that, and check them too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
