wjones127 commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r917010322
##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -105,9 +106,21 @@ class GcsTestbench : public ::testing::Environment {
error += " (exe not found)";
continue;
}
-
- server_process_ = bp::child(exe_path, "-m", "testbench", "--port",
port_, group_);
- if (server_process_.valid() && server_process_.running()) break;
+ // TODO: should I be worried about lifetime of this variable?
+ bp::ipstream output;
Review Comment:
When I made it a member variable, the server would become unresponsive
halfway through the tests. Possibly some buffer filling up and refusing new
input? Unclear.
But leaving as is seems to not have any visible negative consequences when I
run the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
