drin commented on code in PR #13509:
URL: https://github.com/apache/arrow/pull/13509#discussion_r917045351
##########
cpp/src/arrow/compute/exec/plan_test.cc:
##########
@@ -933,6 +933,38 @@ TEST(ExecPlanExecution, SourceGroupedSum) {
}
}
+TEST(ExecPlanExecution, SourceMinMaxScalar) {
+ for (bool parallel : { false, true }) {
+ SCOPED_TRACE(parallel ? "parallel/merged" : "serial");
+
+ auto input = MakeGroupableBatches(/*multiplicity=*/parallel ? 100 : 1);
+ auto minmax_opts = std::make_shared<ScalarAggregateOptions>();
+ auto expected_value = StructScalar::Make(
Review Comment:
I tried looking at the function and searching for usages but I couldn't
figure it out. If you know how to do it, I can update it. I wasn't sure if a
StructScalar is essentially an object (e.g. `{ -8, 12}` would be a 2 field
struct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
