alamb commented on code in PR #2797:
URL: https://github.com/apache/arrow-datafusion/pull/2797#discussion_r917090447
##########
datafusion/physical-expr/Cargo.toml:
##########
@@ -44,6 +44,7 @@ arrow = { version = "17.0.0", features = ["prettyprint"] }
blake2 = { version = "^0.10.2", optional = true }
blake3 = { version = "1.0", optional = true }
chrono = { version = "0.4", default-features = false }
+chronoutil = "0.2.3"
Review Comment:
I am somewhat concerned about adding dependencies (and this particular crate
seems to be maintained by a single person) -- however, since it is so small
(and MIT licensced), we could also just inline the functions we care about.
Any thoughts @andygrove or @thinkharderdev ?
https://github.com/olliemath/chronoutil/blob/main/src/delta.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]