avantgardnerio commented on code in PR #2031:
URL: https://github.com/apache/arrow-rs/pull/2031#discussion_r917120271
##########
arrow/src/datatypes/types.rs:
##########
@@ -191,3 +194,147 @@ impl ArrowTimestampType for TimestampNanosecondType {
TimeUnit::Nanosecond
}
}
+
+impl IntervalYearMonthType {
+ pub fn from(
Review Comment:
I just tried:
```
impl From<(i32, i32, i32> for <IntervalMonthDayNanoType as
ArrowPrimitiveType>::Native {
fn from(_: (i32, i32, i32)) -> Self {
todo!()
}
}
```
as a test. I got 902 compile errors, I think the root cause is
https://doc.rust-lang.org/error-index.html#E0117
Rust doesn't like it when you try to extend `i32`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
