avantgardnerio commented on code in PR #2031:
URL: https://github.com/apache/arrow-rs/pull/2031#discussion_r917152007
##########
arrow/src/datatypes/types.rs:
##########
@@ -191,3 +194,166 @@ impl ArrowTimestampType for TimestampNanosecondType {
TimeUnit::Nanosecond
}
}
+
+impl IntervalYearMonthType {
+ /// Creates a IntervalYearMonthType
Review Comment:
Yes, I struggled a lot with this. It's very confusing the distinction
between these. It technically returns a `<Date64Type as
IntervalYearMonthType>::Native` which is just an `i32`. I question where to
even put these methods, or if they belong on this impl, or what to call them in
the first place. I think the awkwardness comes from arrow not really having a
row, so heretofor there was nothing that operated on an individual value, but
also thus some bad tests that did not properly parse/populate these, so I think
some standard way to convert would be very helpful, hence the addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
