v0y4g3r commented on PR #2855: URL: https://github.com/apache/arrow-datafusion/pull/2855#issuecomment-1179468808
> @v0y4g3r I'd like to start understanding more about the efforts here. Is the plan to put this behind a cargo `feature` so that we can switch between `arrow` and `arrow2`? No, it's simply about upgrading dependencies. But I'm also interested in something like defining a trait to hide the API differences between arrow and arrow2 and use cargo feature to provide an option. But I have no ideas on how to implement that now. > There are some license headers missing: > > ``` > NOT APPROVED: ballista/rust/core/src/memory_stream.rs (./ballista/rust/core/src/memory_stream.rs): false > NOT APPROVED: datafusion/src/physical_plan/sort.rs (./datafusion/src/physical_plan/sort.rs): false > NOT APPROVED: datafusion/tests/sql_integration.rs (./datafusion/tests/sql_integration.rs): false > NOT APPROVED: datafusion-physical-expr/src/test_util.rs (./datafusion-physical-expr/src/test_util.rs): false > ``` Seems like current arrow2 branch doesn't have license header. But it's ok I added headers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
