amol- commented on PR #13409: URL: https://github.com/apache/arrow/pull/13409#issuecomment-1180241621
> I'm not completely against this but having `FilteredDataset` instead of something like `Query` might be a bit short-sighted. What happens if a user wants to add a dynamic column (project)? > > If you had both a projection expression and a filter expression that might be more close to what scanner / datasets provides today. @westonpace I'm not particularly attached to the `FilteredDataset` name, I just want to avoid using the `Query` name explicitly to ensure we avoid hinting users that it's ever supposed to become a fully fledged query system at the moment. They can use IBIS if they are looking for that. I also dislike the idea of reusing the `Scanner` class as it smells like hijacking its data read responsibility. I wanted a name that conveys correctly the idea of something that represents a dataset with an applied transformation and to which additional transformations can be applied. Maybe `QueriedDataset` could do? Smells a lot like the query already happened, so not exactly what I was looking for. I'm open to suggestions. Naming things correctly seems hard, I could try invalidating some caches instead ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
