[GitHub] [arrow] pitrou commented on a diff in pull request #13497: ARROW-16970: [C++][Gandiva] ENCODE(UTF-8 -> UTF-16BE and UTF-8 -> UTF-16LE) and DECODE(UTF-16BE -> UTF-8 and UTF-16LE -> UTF-8)

[GitBox]

pitrou commented on code in PR #13497:
URL: https://github.com/apache/arrow/pull/13497#discussion_r917940285


##########
cpp/src/gandiva/gdv_string_function_stubs.cc:
##########
@@ -20,6 +20,7 @@
 #include "gandiva/gdv_function_stubs.h"
 
 #include <utf8proc.h>
+#include <boost/algorithm/string/predicate.hpp>

Review Comment:
   Do we really want to depend on boost for something as basic as ASCII 
case-insentive comparison?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org