rok commented on code in PR #13440:
URL: https://github.com/apache/arrow/pull/13440#discussion_r917955333
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -533,6 +533,21 @@ test_that("extract yday from timestamp", {
)
})
+test_that("extract qday from timestamp", {
+ compare_dplyr_binding(
+ .input %>%
+ mutate(x = qday(datetime)) %>%
+ collect(),
+ test_df
Review Comment:
Ok, [ARROW-16142](https://issues.apache.org/jira/browse/ARROW-16142) was
resolved so this is now ready.
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -719,6 +734,22 @@ test_that("extract yday from date", {
)
})
+test_that("extract qday from date", {
+ compare_dplyr_binding(
+ .input %>%
+ mutate(x = qday(date)) %>%
+ collect(),
+ test_df
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
