xudong963 commented on PR #2858: URL: https://github.com/apache/arrow-datafusion/pull/2858#issuecomment-1180550312
> Perhaps some unit tests in datafusion/optimizer/src/rewrite_disjunctive_predicate.rs and then a explain test for q18 showing the inner join? Currently, q19 can't be converted to inner join, because the logic of `cross join -> inner join` is in planner not in optimizer > I think the very nice code structure in datafusion/optimizer/src/rewrite_disjunctive_predicate.rs would make it quite easy to write unit tests. Yes, added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
