comphead commented on code in PR #2840:
URL: https://github.com/apache/arrow-datafusion/pull/2840#discussion_r918284863
##########
datafusion/proto/src/from_proto.rs:
##########
@@ -656,21 +658,22 @@ impl TryFrom<&protobuf::ScalarListValue> for ScalarValue {
fn try_from(
scalar_list_value: &protobuf::ScalarListValue,
) -> Result<Self, Self::Error> {
- use protobuf::{scalar_type::Datatype, PrimitiveScalarType};
+ if 2 > 1 {
Review Comment:
Right,I added this to check if this code part is used. We have roundtrips
tests for lists and nested lists in `round_trip_scalar_values` which passed.
I'm wondering if ballista tests are in CI? Otherwise this code looks useless
and can be dropped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
