lidavidm commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r918390746
##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -106,8 +110,27 @@ class GcsTestbench : public ::testing::Environment {
continue;
}
- server_process_ = bp::child(exe_path, "-m", "testbench", "--port",
port_, group_);
- if (server_process_.valid() && server_process_.running()) break;
+ bp::ipstream output;
+ server_process_ = bp::child(exe_path, "-m", "testbench", "--port",
port_, group_,
+ bp::std_err > output);
+ // Wait for message: "* Restarting with"
+ auto testbench_is_running = [&output, this](bp::child& process) {
+ std::string line;
+ std::chrono::time_point<std::chrono::system_clock> end =
+ std::chrono::system_clock::now() + std::chrono::seconds(10);
Review Comment:
Hmm, so this is a local system timeout -> a monotonic clock is what you want
Those other timeouts are deadlines -> I think those go across the wire (gRPC
has deadline propagation) and so need to be an actual time point in order to be
comparable across machines
That said it's not a big deal here, hence the nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
