liukun4515 commented on issue #2837: URL: https://github.com/apache/arrow-datafusion/issues/2837#issuecomment-1181218850
> In my mind, if we we always ran 'constant folding' on an `Expr` then checking for a constant should be a matter of calling `matches!(expr, Expr::Literal)` > > In other words, I had hoped that the `constant folding` pass was a general purpose mechanism to detect constants I go through the code about optimizer and simplify expr, and find some codes about constant folding. I will take more time to look this carefully and give my feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
