wjones127 commented on PR #13577: URL: https://github.com/apache/arrow/pull/13577#issuecomment-1181286899
> Seems reasonable to me. Is it possible to test this against a generated dataset to make sure nothing breaks there? Do these tests from R seem sufficient? https://github.com/apache/arrow/blob/81af2912b5e088c83631df4cfd52e6d6df2878dc/r/tests/testthat/helper-filesystems.R#L130-L156 I pulled the changes from this PR into https://github.com/apache/arrow/pull/13542, so the above tests will run in CI there. (I can confirm they pass locally for GCS and S3.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
