pitrou commented on code in PR #13528:
URL: https://github.com/apache/arrow/pull/13528#discussion_r918626859
##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -30,8 +30,17 @@
namespace arrow {
namespace engine {
+/// Information resulting from converting a Substrait relation.
+struct DeclarationInfo {
+ /// The compute declaration produced thus far.
+ compute::Declaration declaration;
+
+ /// The number of columns returned by the declaration.
+ size_t num_columns;
Review Comment:
@jvanstraten Right, it's basically the convention used accross Arrow. That
said, I do not really find it weird because frequently you'll act on sizes by
adding/removing offsets from them - and those offsets are usually signed. It
makes sense to make all integers signed, IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
