Ted-Jiang commented on code in PR #2044:
URL: https://github.com/apache/arrow-rs/pull/2044#discussion_r919617920
##########
parquet/src/file/serialized_reader.rs:
##########
@@ -526,6 +543,34 @@ impl<T: Read> SerializedPageReader<T> {
page_offset_index: None,
seen_num_data_pages: 0,
has_dictionary_page_to_read: false,
+ page_bufs: Default::default(),
+ };
+ Ok(result)
+ }
+
+ /// Creates a new serialized page reader from file source.
+ pub fn new_with_page_offsets(
+ buf: T,
Review Comment:
Yes, but i try to create an Empty T not succeeded.
So i try to make buf `option` it will make a lot code change and break Api
Any suggestion?😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
