projjal commented on code in PR #13446:
URL: https://github.com/apache/arrow/pull/13446#discussion_r919630065
##########
cpp/src/gandiva/projector.cc:
##########
@@ -75,6 +92,17 @@ Status Projector::Make(SchemaPtr schema, const
ExpressionVector& exprs,
// Verify if previous projector obj code was cached
if (prev_cached_obj != nullptr) {
is_cached = true;
+ } else if (sec_cache != nullptr) {
+ std::shared_ptr<arrow::Buffer> arrow_buffer =
sec_cache->Get(cache_key.Hash());
Review Comment:
Using just hash as key might lead to collisions..also you need to take into
account the cpu features since the generated code will be different in
different cpus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
