projjal commented on code in PR #13565:
URL: https://github.com/apache/arrow/pull/13565#discussion_r919954092
##########
cpp/src/gandiva/precompiled/arithmetic_ops.cc:
##########
@@ -469,6 +469,16 @@ BITWISE_NOT(int64)
#undef DATE_TYPES
#undef NUMERIC_BOOL_DATE_TYPES
#undef NUMERIC_DATE_TYPES
+
+#define CEILING(TYPE) \
+ FORCE_INLINE \
+ gdv_int64 ceiling_##TYPE(gdv_##TYPE in1) { return
static_cast<gdv_##TYPE>(ceil(in1)); }
Review Comment:
should be cast to int64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
