nealrichardson commented on a change in pull request #8198:
URL: https://github.com/apache/arrow/pull/8198#discussion_r488983097
##########
File path: .github/workflows/dev.yml
##########
@@ -59,42 +59,42 @@ jobs:
continue-on-error: true
run: archery docker push ubuntu-lint
- docs:
- name: Sphinx and API documentations
- runs-on: ubuntu-latest
- if: github.event_name == 'push'
- steps:
- - name: Checkout Arrow
- uses: actions/checkout@v2
- with:
- fetch-depth: 0
- - name: Fetch Submodules and Tags
- shell: bash
- run: ci/scripts/util_checkout.sh
- - name: Free Up Disk Space
- shell: bash
- run: ci/scripts/util_cleanup.sh
- - name: Cache Docker Volumes
- uses: actions/cache@v1
- with:
- path: .docker
- key: ubuntu-18.04-${{ hashFiles('cpp/**') }}
- restore-keys: ubuntu-18.04-
- - name: Setup Python
- uses: actions/setup-python@v1
- with:
- python-version: 3.8
- - name: Setup Archery
- run: pip install -e dev/archery[docker]
- - name: Execute Docker Build
- run: |
- sudo sysctl -w kernel.core_pattern="core.%e.%p"
- ulimit -c unlimited
- archery docker run ubuntu-docs
- - name: Docker Push
- if: success() && github.event_name == 'push' && github.repository ==
'apache/arrow'
- continue-on-error: true
- run: archery docker push ubuntu-docs
+ # docs:
Review comment:
Specifically, I meant why not delete rather than comment out.
Regardless of bugs/performance, it doesn't make sense to me to run a heavy
job on every commit and also nightly. That's redundant. Nightly seems
sufficient to me, but regardless we should drop one or the other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
