pitrou commented on code in PR #13577:
URL: https://github.com/apache/arrow/pull/13577#discussion_r920300795
##########
r/R/io.R:
##########
@@ -241,7 +241,9 @@ mmap_open <- function(path, mode = c("read", "write",
"readwrite")) {
make_readable_file <- function(file, mmap = TRUE, compression = NULL,
filesystem = NULL) {
if (inherits(file, "SubTreeFileSystem")) {
filesystem <- file$base_fs
- file <- file$base_path
+ # SubTreeFileSystem adds a slash to base_path, but filesystems will reject
file names
+ # with trailing slashes, so we need to remove it here.
+ file <- sub("/$", "", file$base_path)
Review Comment:
No, I am asking something else. It seems that this code is replacing `file`
(a FileSystem instance) with a file path, is that right? And below, the file
path `file` will be treated as a local filesystem path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
