westonpace commented on code in PR #13518:
URL: https://github.com/apache/arrow/pull/13518#discussion_r920364266
##########
cpp/src/arrow/dataset/scanner_test.cc:
##########
@@ -1445,9 +1446,13 @@ DatasetAndBatches MakeBasicDataset() {
equal(field_ref("c"), literal(23)),
equal(field_ref("c"), literal(47)),
},
- [](compute::ExecBatch* batch, const RecordBatch&) {
+ [](compute::ExecBatch* batch, const RecordBatch&, size_t
guarantee_index) {
// a placeholder will be inserted for partition field "c"
- batch->values.emplace_back(std::make_shared<Int32Scalar>());
+ if (guarantee_index == 0) {
+ batch->values.emplace_back(std::make_shared<Int32Scalar>(23));
+ } else {
+ batch->values.emplace_back(std::make_shared<Int32Scalar>(47));
+ }
Review Comment:
This seems like a spot-fix. Perhaps a more general fix would be to fix the
`DatasetAndBatchesFromJSON` function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
