alamb commented on issue #85: URL: https://github.com/apache/arrow-ballista/issues/85#issuecomment-1183622800
@liukun4515 I think adding trace_id and query_id to the log entries would be very valuable. I think such information exists in the `SessionContext` though to use it all calls to `info!`, `warn!`, etc log macros would need to have a ctx parameter threaded through. I think the `tracing!` library has some way to avoid threading using a thread local variable, but I am not sure if works with `async` 🤔 In IOx we went with a somewhat more sophisticated "distributed tracing" infrastructure of https://www.jaegertracing.io/ and have code that converts the query metrics from datafusion into distributed traces: https://github.com/influxdata/influxdb_iox/blob/main/iox_query/src/exec/query_tracing.rs#L111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
