kou commented on PR #13598: URL: https://github.com/apache/arrow/pull/13598#issuecomment-1183797504
In general, I want to keep examples as simple as possible for easy to understand by users. For example, minimal dependencies, straightforward implementations and so on. In this case, I don't want to do this because it increases a (small) dependency (`example_utils.h`). How about removing `ABORT_ON_FAILURE()` and using `ARROW_RETURN_NOT_OK()` with non-`main()` function like https://github.com/apache/arrow/blob/master/cpp/examples/arrow/join_example.cc instead of using `ABORT_ON_FAILURE()` in `main()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
