sunchao commented on code in PR #2063:
URL: https://github.com/apache/arrow-rs/pull/2063#discussion_r920717025
##########
arrow/src/array/array_dictionary.rs:
##########
@@ -151,6 +151,28 @@ impl<K: ArrowPrimitiveType> DictionaryArray<K> {
Ok(array.into())
}
+ /// Create a new DictionaryArray directly from specified keys
+ /// (indexes into the dictionary) and values (dictionary)
+ /// array, and the corresponding ArrayData. This is used internally
+ /// for the usage like filter kernel.
+ ///
+ /// # Safety
+ ///
+ /// The input keys, values and data must form a valid DictionaryArray,
+ /// or undefined behavior can results.
Review Comment:
"can results" -> "can occur".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
