alamb opened a new pull request, #2066: URL: https://github.com/apache/arrow-rs/pull/2066
# Which issue does this PR close? Closes https://github.com/apache/arrow-rs/issues/2065 # Rationale for this change Depending on the usecase sometimes one wants the days of week to start from Sunday or Monday. Dates :shrug: @ovr added the `weekday0` kernel in https://github.com/apache/arrow-rs/pull/2052 But now the names are `weekday` and `weekday0` which I think might be confusing to the average reader # What changes are included in this PR? Rename the kernels to follow the chrono naming scheme `num_days_from_sunday` and `num_days_from_monday` https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html#method.num_days_from_sunday https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html#method.num_days_from_monday # Are there any user-facing changes? Yes, name of the `compute::kernels::temporal::weekday` (which is present in arrow 18) is renamed to `compute::kernels::temporal::num_days_since_monday` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
